ref(nuxt): Use addVitePlugin instead of deprecated vite:extendConfig#19464
Merged
ref(nuxt): Use addVitePlugin instead of deprecated vite:extendConfig#19464
addVitePlugin instead of deprecated vite:extendConfig#19464Conversation
s1gr1d
changed the title
addVitePlugin instead of deprecated vite:extendConfig
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
andreiborza
reviewed
Feb 27, 2026
| }) { | ||
| const hooks: Record<string, HookCallback[]> = {}; | ||
| setupSourceMaps({ debug: true }, mockNuxt as unknown as Nuxt, mockAddVitePlugin); | ||
| await mockNuxt.triggerHook('modules:done'); |
Member
There was a problem hiding this comment.
m: Maybe we can assert the plugin to be null before the done hook is called to make sure it really happens after the hook, wdyt?
Member
Author
There was a problem hiding this comment.
This cannot be null as it runs at the very beginning already. But I'll add tests to verify the correct filesToDeleteAfterUpload is used.
s1gr1d
changed the title
addVitePlugin instead of deprecated vite:extendConfigaddVitePlugin instead of deprecated vite:extendConfig
s1gr1d
changed the title
addVitePlugin instead of deprecated vite:extendConfigaddVitePlugin instead of deprecated vite:extendConfig
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vite:extendConfigis deprecated, so source maps handling will be done in a plugin which is added withaddVitePluginfrom Nuxt.Also updated the existing tests so they can test the new plugin functionality.
Closes #19345